Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter, config, environment variable for pamaters of checks #39

Open
moylop260 opened this issue Oct 27, 2022 · 1 comment
Open
Assignees
Labels
enhancement New feature or request stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@moylop260
Copy link
Collaborator

moylop260 commented Oct 27, 2022

e.g. MIN_PRIORITY = 99

Almost DFT_* variables should be configurables from parameters, configuration file or environments and so on

Remove the TODO comments too:

  • # TODO: Add self.config.min_priority instead of DFTL_MIN_PRIORITY

You can get all the related TODO comments running the following command:

  • pylint -d all -e fixme src
@moylop260 moylop260 added the enhancement New feature or request label Oct 27, 2022
@github-actions
Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

2 participants