[ADD] Add warning for related fields with store=True

[lef-adhoc]

This PR adds a warning for related fields with store=True, as it is no longer necessary to store related fields for grouping, aggregating, or sorting in Odoo 18. The warning encourages developers to remove store=True unless strictly required, optimizing performance and reducing disk space usage.

More details can be found in the related Odoo PR: odoo/odoo#127353

[pedrobaeza]

I think this should be in pylint-odoo cc @moylop260

[bruno-zanotti]

LGTM!

[legalsylvain]

I think this should be in pylint-odoo cc @moylop260

I don't get it. It can be totally valid to write a store=True related field, AFAIK.

[pedrobaeza]

If not needed (talking about performance reasons), why do it?

[legalsylvain]

If not needed (talking about performance reasons), why do it?

I missed something. If I understand correctly : store=True (for related fields) :

• is not needed anymore to use group by, etc...
• is needed (sometimes, of course) for performance reason.

For me It can still be valid.

[pedrobaeza]

In theory, you don't get performance penalty when not storing for that. That's why there's a warning.

[legalsylvain]

That's why there's a warning

I don't see new warning in the PR : odoo/odoo#127353

If you talk about the warning introduced by the current PR, #98, it is just a warning. maybe something should be done, but related="xx.xxx", store="True" is still valid.

I can not figure out how a non stored field can generate exactly the same performance as a stored field, as it is introducing an extra join in the SQL.

Let me know if I missed something.

[pedrobaeza]

OK, then let's not put the warning at all if there are drawbacks removing the store.

[legalsylvain]

OK, then let's not put the warning at all if there are drawbacks removing the store.

Well, the documentation in https://github.com/OCA/odoo-module-migrator says :

Indicates that you should check something. There may be something to do to make the module work. For example:

19:37:55 WARNING Replaced dependency of 'account_analytic_analysis' with 'contract' (Moved to OCA/contract)

So for me, it's ok to introduce this warning or not. (matter of taste).

[desdelinux]

pylint-odoo

This is a good suggestion for odoo-module-migrator. I don't think it adds much to pylint-odoo.

cc @pedrobaeza

[pedrobaeza]

Right, I understood that it was somehow mandatory with no performance penalty

[jjscarafia]

So? we proceed with merging?