Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] read_group refactor script #82

Merged
merged 2 commits into from
Nov 22, 2023
Merged

[ADD] read_group refactor script #82

merged 2 commits into from
Nov 22, 2023

Conversation

bruno-zanotti
Copy link
Contributor

No description provided.

@bruno-zanotti bruno-zanotti force-pushed the script-read_group branch 2 times, most recently from cf35c3c to 58c5d06 Compare November 21, 2023 13:20
@bruno-zanotti bruno-zanotti force-pushed the script-read_group branch 2 times, most recently from a97651a to 4dfd8a0 Compare November 21, 2023 13:33
@jjscarafia
Copy link
Collaborator

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch master-ocabot-merge-pr-82-by-jjscarafia-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b351ec4. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit b351ec4 into OCA:master Nov 22, 2023
2 checks passed
@jjscarafia jjscarafia deleted the script-read_group branch November 22, 2023 00:14
luisg123v
luisg123v reviewed Mar 14, 2024
View reviewed changes
Copy link

@luisg123v luisg123v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, please provide a meaningful description, because this change has no rationale.

@bruno-zanotti
Copy link
Contributor Author

Next time, please provide a meaningful description, because this change has no rationale.

This PR was made during the OCA Days and we discuss about this in the event, that's why it was merge without description. Anyway is not a change it self, we are just adding an script to handle the migration of the read_group method that has changes in v17 (more info: odoo/odoo#110737)

@luisg123v luisg123v mentioned this pull request Mar 14, 2024
Closed
@luisg123v
Copy link

@bruno-zanotti thanks for the reference, it was very useful.

I am the opinion commits shouldn't have empty messages unless they are very obvious by reading the title.

In this case, a simple "for more info, (Odoo link)" would've been enough IMHO.

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisg123v luisg123v luisg123v left review comments

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bruno-zanotti @jjscarafia @OCA-git-bot @luisg123v