-
-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oca-create-branch: carry over answers from previous branches #541
Conversation
c3ec189
to
cdb9a3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, just a question
def main(new_branch, copier_template, copier_template_vcs_ref, repos): | ||
@click.option( | ||
"--prev-branch", | ||
help="Previous branch where to read some copier answers.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default True?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is actually a branch name.
cdb9a3f
to
00a7584
Compare
Copier is required for oca-create-branch only, and copier 9 does not support python<3.8.
@sbidoul in the repo-maintainer tool will already preserve the repo name and description. Hence, I don't think we need this anymore. Am I wrong? Then we might implement a way to keep other keys but it can be done later. |
I think with repo_description I wanted to preserve the body of the repo README.md. But in practice very few repo have it in a copier answer. So happy to drop oca-create-branch from here and use repo-maintainer-conf for that. Thanks for that work! |
I keep this open for a while and if we are happy with the new solution, I'll remove create_branch.py from this repo. |
Closing since this is now handled by github.com/oca/repo-maintainer-conf |
Carry over the repo name and repo description from previous branch.