Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] l10n_ch_pain_base: Migration to 16.0 #725

Open
wants to merge 28 commits into
base: 16.0
Choose a base branch
from

Conversation

BT-anieto
Copy link

@BT-anieto BT-anieto commented Jun 11, 2024

Removed dependency on l10n_ch_base_bank

alexis-via and others added 27 commits June 11, 2024 14:56
Fix sepa compute method
* [11.0][FIX] l10n_ch_pain_base - fix error message

Fix of the field used on the UsserError message when no CCP account is set.
The field 'partner_bank.name' doesn't exist, the corresponding field is 'partner_bank.acc_number'
Plus drop the need of ISR reference type on invoice
# This is the 1st commit message:

85a93e8

# This is the commit message OCA#2:

use qr_iban validation methode

# This is the commit message OCA#3:

fix commit

# This is the commit message OCA#4:

remove debug info
produce a pain001 expected (according to SIX
implementation-guidelines-ct)
Currently translated at 7.6% (1 of 13 strings)

Translation: l10n-switzerland-14.0/l10n-switzerland-14.0-l10n_ch_pain_base
Translate-URL: https://translation.odoo-community.org/projects/l10n-switzerland-14-0/l10n-switzerland-14-0-l10n_ch_pain_base/it/
@BT-anieto BT-anieto force-pushed the 16.0-mig-l10n_ch_pain_base branch 2 times, most recently from f5a74ba to a0ee66e Compare June 12, 2024 10:33
@BT-anieto
Copy link
Author

@davidwul Here you have the PR without the dependency and with the proper OCA workflow (I hope). Could you review and close yours? I will add now the updated PR for the module l10n_ch_pain_credit_transfer

@BT-anieto BT-anieto force-pushed the 16.0-mig-l10n_ch_pain_base branch from a0ee66e to 3f6d5e6 Compare June 12, 2024 10:35
@BT-anieto BT-anieto mentioned this pull request Jun 12, 2024
12 tasks
@BT-anieto BT-anieto force-pushed the 16.0-mig-l10n_ch_pain_base branch from 3f6d5e6 to 186f2e0 Compare June 12, 2024 12:20
@davidwul
Copy link
Contributor

@BT-anieto
great, thanks LGTM
👍

@BT-anieto BT-anieto force-pushed the 16.0-mig-l10n_ch_pain_base branch from 186f2e0 to 92d8c1a Compare June 13, 2024 15:38
Remove dependency on l10n_ch_base_bank since it is obsolete.
Add check for partner bank QR reference
@BT-anieto BT-anieto force-pushed the 16.0-mig-l10n_ch_pain_base branch from 92d8c1a to c9e3f7e Compare July 11, 2024 13:36
@ecino
Copy link

ecino commented Oct 14, 2024

/ocabot migration l10n_ch_pain_base

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 14, 2024
@ecino
Copy link

ecino commented Oct 14, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-725-by-ecino-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 14, 2024
Signed-off-by ecino
@OCA-git-bot
Copy link
Contributor

@ecino your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-725-by-ecino-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@ecino
Copy link

ecino commented Oct 14, 2024

@BT-anieto Thanks for your contribution! It looks like the module is conflicting with the tests of ebill_postfinance module. Please have a look at it.

@BT-anieto
Copy link
Author

Good morning @ecino I opened this PR 4 months ago. I do not have time to make any further modifications at this time. I'm sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.