Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD][14.0] new addon contract_sequence #820

Closed
wants to merge 8 commits into from
Closed

[ADD][14.0] new addon contract_sequence #820

wants to merge 8 commits into from

Conversation

scigghia
Copy link
Contributor

@scigghia scigghia commented May 4, 2022

This addon adds sequence to contract and contract template
it sets also a default sequence for contract in company settings

@scigghia scigghia force-pushed the 14-add_contract_sequence branch 4 times, most recently from d1b6f2e to ff14faa Compare May 5, 2022 06:47
@scigghia scigghia changed the title [14.0] new addon contract_sequence [ADD][14.0] new addon contract_sequence May 6, 2022
@angelmoya
Copy link
Member

Tested on runboat, I can not create a customer contract.

@scigghia scigghia force-pushed the 14-add_contract_sequence branch 3 times, most recently from a4f0634 to 6b79a97 Compare May 6, 2022 15:34
@scigghia
Copy link
Contributor Author

scigghia commented May 6, 2022

thank you for your feedback @angelmoya i fixed some default values and now should be fine
but i think runboat for this pr is broken

@scigghia
Copy link
Contributor Author

scigghia commented May 7, 2022

@sbidoul could you take a look to the runboat please?

@sbidoul
Copy link
Member

sbidoul commented May 7, 2022

likely due to this: OCA/oca-ci#29

@scigghia scigghia force-pushed the 14-add_contract_sequence branch 2 times, most recently from 20ae5e5 to 3dbbe5f Compare May 10, 2022 10:38
@scigghia
Copy link
Contributor Author

@angelmoya did you have the opportunty to test? now the runboat is running :)

@angelmoya
Copy link
Member

Nice, is working right... but codecov is to low.. if you can add tests would be great

@scigghia scigghia force-pushed the 14-add_contract_sequence branch 2 times, most recently from aa7b4cb to c391626 Compare May 21, 2022 12:30
@scigghia
Copy link
Contributor Author

why travis and runboat are crashing on account_banking_mandate ?
@sbidoul

@sbidoul
Copy link
Member

sbidoul commented May 21, 2022

That was an expired certificate on odoo-community.org again. It's resolved now please retry.

@scigghia scigghia force-pushed the 14-add_contract_sequence branch from c391626 to c0a7db4 Compare May 21, 2022 14:00
@scigghia
Copy link
Contributor Author

That was an expired certificate on odoo-community.org again. It's resolved now please retry.

thank you @sbidoul

@scigghia scigghia force-pushed the 14-add_contract_sequence branch 4 times, most recently from fcb4d76 to 2b87b9c Compare May 27, 2022 15:52
@scigghia scigghia force-pushed the 14-add_contract_sequence branch 3 times, most recently from 36a6456 to dd5a3de Compare June 10, 2022 10:01
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 9, 2022
@scigghia
Copy link
Contributor Author

no one interested in this module?

@rousseldenis rousseldenis added this to the 14.0 milestone Oct 10, 2022
@rousseldenis
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 14.0.

@OCA-git-bot OCA-git-bot force-pushed the 14-add_contract_sequence branch from dd5a3de to 0264cdf Compare October 10, 2022 08:32
rousseldenis
rousseldenis requested changes Oct 10, 2022
View reviewed changes
contract_sequence/__manifest__.py Outdated Show resolved Hide resolved
contract_sequence/models/contract.py
"contract_sequence.seq_contract_auto"
)
if not result:
raise UserWarning(_("No default sequence found!"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please raise Odoo exception (UserError)

contract_sequence/models/contract.py
raise UserWarning(_("No default sequence found!"))
return result

sequence_id = fields.Many2one(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put fields definition on top

contract_sequence/models/contract.py
help="This field contains the information related to the numbering "
"of the journal entries of this journal.",
copy=False,
default=get_default_sequence,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use lambda

contract_sequence/models/contract_template.py


class ContractTemplate(models.Model):
_inherit = "contract.template"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the sequencing wanted on templates ?

contract_sequence/tests/test_contract_sequence.py


@tagged("post_install", "-at_install")
class TestContractSequence(TransactionCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use SavepointCase

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 16, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 19, 2023
@scigghia @rousseldenis
Update contract_sequence/__manifest__.py
77b67b8 
Co-authored-by: Denis Roussel (ACSONE) <[email protected]>
@github-actions github-actions bot closed this Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis requested changes

Assignees
No one assigned
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@scigghia @angelmoya @sbidoul @rousseldenis @OCA-git-bot