-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [ADD] recurring_payment_stripe module #1151
base: 16.0
Are you sure you want to change the base?
Conversation
[16.0][ADD] recurring_payments_stripe: Add recurring payments with stripe
[16.0][ADD] recurring_payments_stripe: Add stripe library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a Stripe API to run tests?
It would be nice to see a tests/test_sale_subscription.py
and I guess this would require some kind of mocking of the actual Stripe API.
metadata={"odoo_invoice_id": str(invoice.id)}, | ||
) | ||
|
||
# Manejar el resultado del PaymentIntent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments should be in English.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed translation problem in the comment
{ | ||
"name": "Recurring Payments with Stripe", | ||
"version": "16.0.1.0.0", | ||
"summary": """ Recurring Payments with Stripe """, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the spacing before and after the """
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed spaces before and after within summary content
Module name shouldn't contain plurals. Coupling this also to subscription module doesn't seem modular. A base module with the API, and another for linking with subscriptions is a better design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the addon, and it appears to be functioning well. However, I’ve noticed that while the payment for the first invoice related to the subscription is being correctly recorded, the corresponding entries are not being created in the payment_transaction table for subsequent invoices. While the payment for the first invoice shows up as expected, the payment transactions for the following invoices are not being registered in payment_transaction.
Agree |
Add recurring payments with stripe