Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] contract_sale_invoicing: Migration to version 17.0 #1106

Merged
merged 12 commits into from
Aug 24, 2024

Conversation

juanjosesegui-tecnativa
Copy link
Contributor

@Tecnativa TT50111

carlosdauden and others added 9 commits July 25, 2024 15:53
[REF] Contract Sale Invoicing: update translations

[IMP] - Assert that the predecessor is available for new link at uncancel

[RMV] - remove usless changes

[RMV] - Remove usless field recurring_invoices

after the total isolation between contract model and account analytic one.
recurring_invoices which was used to mark analytic account as contract became usless

[IMP] - P3 syntax

[IMP] - use @openupgrade.migrate() and openupgrade.logged_query

[IMP] - drop transient table in migration script
replaced contract's account_analytic_id by group_id
@juanjosesegui-tecnativa
Copy link
Contributor Author

ping @pedrobaeza

@pedrobaeza
Copy link
Member

/ocabot migration contract_sale_invoicing

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 8, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 8, 2024
12 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash administrative commits.

imagen

@juanjosesegui-tecnativa juanjosesegui-tecnativa force-pushed the 17.0-mig-contract_sale_invoicing branch from 643c6e6 to 262ab4f Compare August 9, 2024 07:13
@juanjosesegui-tecnativa
Copy link
Contributor Author

Please squash administrative commits.

imagen

Done!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM :)

Still having problems when sending email in Contracts but i thinks is related with module contract base

image

Please review my comments before.

contract_sale_invoicing/readme/USAGE.md Outdated Show resolved Hide resolved
@juanjosesegui-tecnativa juanjosesegui-tecnativa force-pushed the 17.0-mig-contract_sale_invoicing branch from 262ab4f to aefe529 Compare August 13, 2024 10:36
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1106-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3febde5 into OCA:17.0 Aug 24, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aa9e6c4. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-contract_sale_invoicing branch August 24, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.