Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] contract_mandate: Migration to 16.0 #1070

Merged
merged 44 commits into from
Aug 19, 2024
Merged

[16.0][MIG] contract_mandate: Migration to 16.0 #1070

merged 44 commits into from
Aug 19, 2024

Conversation

adriapalleja
Copy link

No description provided.

carlosdauden and others added 30 commits April 3, 2024 07:56
@carlosdauden
[9.0][ADD] contract_mandate: New module
dad4d01
@oca-transbot
OCA Transbot updated translations from Transifex
cb18b35
@carlosdauden
[MIG] contract_mandate: Migration to 10.0
39d639c
@ThomasBinsfeld
[MIG] Contract Mandate to 12.0
1db809a
@sbejaoui
[FIX] - Fix unit tests
7239854
@ThomasBinsfeld
[REF] Contract Mandate: remove unused objects in unit tests
6bc9b36
@OCA-git-bot
[UPD] README.rst
025d421
@OCA-git-bot
[ADD] icon.png
45a4b0c
@oca-travis
[UPD] Update contract_mandate.pot
b93658f
@oca-transbot
Update translation files
454590e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-contract_mandate
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_mandate/
@marylla
Translated using Weblate (German)
290a4ae 
Currently translated at 50.0% (3 of 6 strings)

Translation: contract-12.0/contract-12.0-contract_mandate
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_mandate/de/
@britoederr
Translated using Weblate (Portuguese (Brazil))
f1fdd35 
Currently translated at 100.0% (6 of 6 strings)

Translation: contract-12.0/contract-12.0-contract_mandate
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_mandate/pt_BR/
@liweijie0812
Translated using Weblate (Chinese (Simplified))
fa98673 
Currently translated at 100.0% (6 of 6 strings)

Translation: contract-12.0/contract-12.0-contract_mandate
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_mandate/zh_CN/
@sbejaoui
[12.0][FIX] - contract_mandate: fix inherited method call _prepare_in…
21c0e5b 
…voice
@sbejaoui @pedrobaeza
Update contract_mandate/models/contract.py
abe2d15 
Co-Authored-By: Pedro M. Baeza <[email protected]>
@OCA-git-bot
contract_mandate 12.0.1.0.1
087a881
@rschnapka
Translated using Weblate (German)
611cb1e 
Currently translated at 100.0% (6 of 6 strings)

Translation: contract-12.0/contract-12.0-contract_mandate
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_mandate/de/
@josepmy
Translated using Weblate (Spanish)
1490d9d 
Currently translated at 100.0% (6 of 6 strings)

Translation: contract-12.0/contract-12.0-contract_mandate
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_mandate/es/
@pedrocs-exo
Translated using Weblate (Portuguese)
5aee504 
Currently translated at 16.7% (1 of 6 strings)

Translation: contract-12.0/contract-12.0-contract_mandate
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_mandate/pt/
@alvarorib
Translated using Weblate (Portuguese)
b38e21b 
Currently translated at 100.0% (6 of 6 strings)

Translation: contract-12.0/contract-12.0-contract_mandate
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_mandate/pt/
@OCA-git-bot
[UPD] README.rst
9b07038
@OCA-git-bot
[UPD] README.rst
3338354
@javierjcf
[FIX]contract_mandate: Search mandate from correct company if we get …
0b12632 
…in this method by the contract cron
@OCA-git-bot
contract_mandate 12.0.1.0.2
c99e4f8
@fcolus
Translated using Weblate (Portuguese (Brazil))
807844b 
Currently translated at 100.0% (6 of 6 strings)

Translation: contract-12.0/contract-12.0-contract_mandate
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_mandate/pt_BR/
@willer-mo
[IMP] contract_mandate: black, isort, prettier
b151c8b
@willer-mo
[MIG] contract_mandate: Migration to 13.0
2bea3d3
@oca-travis
[UPD] Update contract_mandate.pot
5df1a14
@OCA-git-bot
[UPD] README.rst
1d8ec17
@hkapatel-initos
[MIG] contract_mandate: Migration to 14.0
fea17c4
weblate and others added 3 commits April 3, 2024 07:56
@weblate
Update translation files
994d672 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-14.0/contract-14.0-contract_mandate
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_mandate/
@Ivorra78
Translated using Weblate (Spanish)
3a678d1 
Currently translated at 100.0% (9 of 9 strings)

Translation: contract-14.0/contract-14.0-contract_mandate
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_mandate/es/
[IMP] contract_mandate: pre-commit stuff
0671cfb
@rousseldenis
Copy link
Contributor

/ocabot migration contract_mandate

@rousseldenis
Copy link
Contributor

@adriapalleja Thanks for this.

Could you follow migration guide : https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0#technical-method-to-migrate-a-module-from-150-to-160-branch ?

And could you fix tests ?

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Apr 4, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 4, 2024
Open
13 tasks
Sou15
Sou15 approved these changes Jun 13, 2024
View reviewed changes
Copy link

@Sou15 Sou15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I tried it locally. The module works, tets work (4/4).

@adriapalleja
Copy link
Author

@rousseldenis Hi! I think this PR is ready to be merged. Could you please merge it please? Thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

@adriapalleja Could you rearrange your commits and your commit messages ?

image

At least, you should have just after pre-commit one, the migration one [MIG][16.0] contract_mandate.

Then, if you have improvements, they should appear clearly with commits like [IMP] contract_mandate: <the improvement>.

Thanks

@adriapalleja adriapalleja force-pushed the 16.0-mig-contract-mandate branch from 6a216e8 to e0130f4 Compare July 8, 2024 14:16
@adriapalleja adriapalleja force-pushed the 16.0-mig-contract-mandate branch from e0130f4 to 704a58b Compare July 8, 2024 14:24
@adriapalleja adriapalleja force-pushed the 16.0-mig-contract-mandate branch from 53c5f8a to 9bd7a32 Compare August 12, 2024 15:11
@adriapalleja
Copy link
Author

Hi @rousseldenis. I fixed the commits following the standards you suggested, thanks!

There is a check failing in CI, but reviewing inside codecov I would say this is properly working and passing tests. Do you think this is ready now?

rousseldenis
rousseldenis approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1070-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7558dd6 into OCA:16.0 Aug 19, 2024
10 of 11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7fcf6d8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sou15 Sou15 Sou15 approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@danypr92 danypr92 danypr92 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs fixing ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.