Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] New module: subscription_oca_purchase #1107

Closed
Tisho99 opened this issue Jul 31, 2024 · 1 comment
Closed

[17.0] New module: subscription_oca_purchase #1107

Tisho99 opened this issue Jul 31, 2024 · 1 comment

Comments

@Tisho99
Copy link
Contributor

Tisho99 commented Jul 31, 2024

Hi, I am planning to create a new module for subscriptions: subscription_oca_purchase.

The module will inherit subscription_oca and do the same for purchases. A subscription_type field will be added to subscriptions and subscriotion templates to make the logic.

Also, a little refactor to the subscription_oca will be needed. I have considered the following changes:

  • Adding the subscription_type field with only the "sale" value.
  • Set required=False in the pricelist field of the subscriptions, and adapt to the change all the functions related to pricelists of the subscription and subscription lines models.

Is anyone interested?

Does anyone see any problems with refactoring oca_subscription?

Other thoughts on this?

@HaraldPanten
Copy link

@Tisho99 I think you can close this issue. Maybe it's better to continue in this one --> #1108

@Tisho99 Tisho99 closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants