From 607c1791c8c5aea4d772f70b976b89b0a7e39f73 Mon Sep 17 00:00:00 2001
From: Damien Crier <damien.crier@foodles.co>
Date: Mon, 23 Oct 2023 08:46:30 +0200
Subject: [PATCH 1/2] IMP: use group product.group_discount_per_so_line instead
 of base.group_no_one

---
 contract/views/contract.xml | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/contract/views/contract.xml b/contract/views/contract.xml
index 1d9a6927cf..9e568d9620 100644
--- a/contract/views/contract.xml
+++ b/contract/views/contract.xml
@@ -232,7 +232,10 @@
                                         attrs="{'readonly': [('automatic_price', '=', True)]}"
                                     />
                                     <field name="specific_price" invisible="1" />
-                                    <field name="discount" groups="base.group_no_one" />
+                                    <field
+                                        name="discount"
+                                        groups="product.group_discount_per_so_line"
+                                    />
                                     <field name="price_subtotal" />
                                     <field name="recurring_interval" invisible="1" />
                                     <field name="recurring_rule_type" invisible="1" />
@@ -333,7 +336,10 @@
                                         attrs="{'readonly': [('automatic_price', '=', True)]}"
                                     />
                                     <field name="specific_price" invisible="1" />
-                                    <field name="discount" groups="base.group_no_one" />
+                                    <field
+                                        name="discount"
+                                        groups="product.group_discount_per_so_line"
+                                    />
                                     <field name="price_subtotal" />
                                     <field name="recurring_interval" invisible="1" />
                                     <field name="recurring_rule_type" invisible="1" />

From 86b3b46e3e7cb0c0d69209f506342c53f7cbea81 Mon Sep 17 00:00:00 2001
From: Damien Crier <damien.crier@foodles.co>
Date: Mon, 23 Oct 2023 10:54:24 +0200
Subject: [PATCH 2/2] add optional attribute on discount field of contract.line

---
 contract/views/contract.xml          | 2 ++
 contract/views/contract_template.xml | 6 +++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/contract/views/contract.xml b/contract/views/contract.xml
index 9e568d9620..74a9c5fe2f 100644
--- a/contract/views/contract.xml
+++ b/contract/views/contract.xml
@@ -235,6 +235,7 @@
                                     <field
                                         name="discount"
                                         groups="product.group_discount_per_so_line"
+                                        optional="show"
                                     />
                                     <field name="price_subtotal" />
                                     <field name="recurring_interval" invisible="1" />
@@ -339,6 +340,7 @@
                                     <field
                                         name="discount"
                                         groups="product.group_discount_per_so_line"
+                                        optional="show"
                                     />
                                     <field name="price_subtotal" />
                                     <field name="recurring_interval" invisible="1" />
diff --git a/contract/views/contract_template.xml b/contract/views/contract_template.xml
index 438f00bd74..b154510f9c 100644
--- a/contract/views/contract_template.xml
+++ b/contract/views/contract_template.xml
@@ -54,7 +54,11 @@
                                 attrs="{'readonly': [('automatic_price', '=', True)]}"
                             />
                             <field name="specific_price" invisible="1" />
-                            <field name="discount" groups="base.group_no_one" />
+                            <field
+                                name="discount"
+                                groups="product.group_discount_per_so_line"
+                                optional="show"
+                            />
                             <field name="price_subtotal" />
                             <field name="recurring_rule_type" invisible="1" />
                             <field name="recurring_interval" invisible="1" />