Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] account_reconciliation_widget error when foreign currency on statement and on bill #415

Closed
TeoGoddet opened this issue Oct 29, 2021 · 3 comments

Comments

@TeoGoddet
Copy link

Hello !
I could not reconcile foreign currency payments,
I investigated and it seems that there is a confusion between
statement_line.currency_id and statement_line.foreign_currency_id at a lot of place

st_line_currency = self.currency_id or statement_currency

"currency_id": st_line.currency_id.id or statement_currency.id,

Did the field change name between 13 and 14 ?

Linked to #359

I had better result with foreign reconciliation with some changes on this.

Fixing

st_line_currency = self.currency_id or statement_currency
isprobably enough to remove the error raised

But we need to fix more to have the UI display correct infos (now we have some place where foreign and company currency are mixed.

I'm working on a PR to fix this.

@TeoGoddet
Copy link
Author

image

@TeoGoddet
Copy link
Author

Finally confirmed that this commit odoo/odoo@caeb782 change currency_id to foreign_currency_id and create a new currency_id equivalent to the journal/statement currency

@ozono when working on #359, did you change any currency_id to something else ?
If not, replacing all currency_id by foreign_currency_id should make it works a lot better, i will try it

@TeoGoddet
Copy link
Author

Resolved by #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant