Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] account_check_report many fixes and improvements #723

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

AaronHForgeFlow
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow commented Apr 9, 2024

[FIX] account_check_report: payment amount should consider current payment and not other payments

[IMP] account_check_report: show amount residual at the payment date, not on today's date

[IMP] account_check_report: show direct refund applied on invoices paid by the check e.g. 2 invoices and a refund for those 2 invoices should appear, even if the refund includes separate invoices

[IMP]account_check_report: button invoices show all related invoices + direct refunds

[IMP] account_check_report: add test coverage

[IMP] account_check_report: do not print more than one line by invoice. Currently, if there are several receivable/payable lines, for example, due to payment terms the invoice appears multiple times

[FIX] Do not show "Check: False" when there is no check number, do not show anything instead.

Kind of forward porting this #397 --> Screenshots for the different fixes are provided there

The changes in the payment document itself can be reverted if only the report is accepted.

@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-fix-account_check_report branch 2 times, most recently from def7142 to 7bf6bc0 Compare April 15, 2024 14:46
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 18, 2024
@AaronHForgeFlow AaronHForgeFlow added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Aug 20, 2024
@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-fix-account_check_report branch 2 times, most recently from 024dcb1 to e62d4fd Compare August 28, 2024 11:18
@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-fix-account_check_report branch 2 times, most recently from fbd26bc to a275bd2 Compare August 30, 2024 08:04
@AaronHForgeFlow
Copy link
Contributor Author

One of the main needs for this fix is the first one:

[FIX] account_check_report: payment amount should consider current payment and not other payments

For example, when having to bills, for $2.99 each and 2 payments for $1 and $ 4 where the matching is the following:

bill1: reconcile with payment 1 --> amount residual left $1.99 (payment 1 applied $1)
bill1: reconcile with payment 2--> amount residual left $0 (payment 2 applied $1.99)
bill2: reconcile with payment 2--> amount residual left $0.98 (payment 2 applied $2.01)

When we print the report on the first payment (right part of the following image) we see that the payment amount is $2.99. This is incorrrect, as only 1$ was applied. The left part of the image shows how it looks after this fix

check_report_paymnet1

Same thing with the report for for the second payment. It pays $1.99 on the first invoice, not the total amount:
check_report_paymnet2

…yment only

not other payments

[IMP] account_check_report: show amount residual at the payment date, not on todays date

[IMP] account_check_report: show direct refund applied on invoices paid by the check
e.g. 2 invoices and a refund for those 2 invoices should appear, even if the refund
includes separate invoices

[IMP]account_check_report: button invoices show all related invoices + direct refunds

[IMP] account_check_report: add test coverage

[IMP] account_check_report: do not print more than one line by invoice. Currently,
if there are several receivable/payable lines, for example, due to payment terms
the invoice appears multiple times
@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-fix-account_check_report branch from a275bd2 to c51ac4e Compare August 30, 2024 08:14
@AaronHForgeFlow
Copy link
Contributor Author

🎶🐛🎶 "cri-cri... cri-cri... criiiiiiick!" 🐜🎶🐛
🐜 "cricket chirp sounds intensify..." 🎶🐛 "cri-criiiiick cri-cri!" 🎶🐜
🐛🐜🎶 "cri-crick cri-crick!" 🎶🐜🐛

@MiquelRForgeFlow
Copy link
Contributor

Who truly makes 🎶 cri-cri 🎶 is the 🪳🦗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants