-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0][IMP] Add both pivot and graph views to account_due_list #185
[10.0][IMP] Add both pivot and graph views to account_due_list #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine for me
👍 pretty usefull and easy improvement |
Please change module version number according https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#version-numbers And where are the definition of those views? |
@pedrobaeza The views aren't really necessary, defaults are pretty ok for me. Will increase the version number right now |
But you should create them with the same defaults, or this module will not be inheritable as dependent modules might create other conflicting views instead of inheriting the main one. |
813c740
to
01f9310
Compare
@pedrobaeza I've just pushed a new rebased patch with related pivot and graph views |
@pedrobaeza Sorry! Wrong patch, will resubmit |
7984848
to
d7cecb8
Compare
@pedrobaeza Now looks fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And what about graph view?
<field name="context">{'search_default_from_invoices': 1}</field> | ||
<field name="view_id" ref="view_payments_tree"/> | ||
<field name="search_view_id" ref="view_payments_filter"/> | ||
<field name="domain">[('account_id.internal_type', 'in', ['receivable', 'payable'])]</field> | ||
</record> | ||
|
||
<record model="ir.actions.act_window.view" id="view_payments_tree_action"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed
<field name="act_window_id" ref="action_invoice_payments"/> | ||
</record> | ||
|
||
<record model="ir.actions.act_window.view" id="view_payments_pivot_action"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed.
d7cecb8
to
dbab2ec
Compare
@pedrobaeza ok! I've done some changes and added the missing graph view, let me know if now looks ok for you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Cherry-picked for v11 in b2addc3 |
Just to improve the account due list representation and pivoting