Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][IMP] Add both pivot and graph views to account_due_list #185

Conversation

robyf70
Copy link
Contributor

@robyf70 robyf70 commented Apr 19, 2018

Just to improve the account due list representation and pivoting

Copy link
Member

@jackjack82 jackjack82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for me

@agb80
Copy link
Member

agb80 commented Apr 27, 2018

👍 pretty usefull and easy improvement

@pedrobaeza
Copy link
Member

Please change module version number according https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#version-numbers

And where are the definition of those views?

@robyf70
Copy link
Contributor Author

robyf70 commented Apr 27, 2018

@pedrobaeza The views aren't really necessary, defaults are pretty ok for me. Will increase the version number right now

@pedrobaeza
Copy link
Member

But you should create them with the same defaults, or this module will not be inheritable as dependent modules might create other conflicting views instead of inheriting the main one.

@robyf70 robyf70 force-pushed the 10.0-add_pivot_and_graph_view_to_account_due_list branch from 813c740 to 01f9310 Compare April 27, 2018 14:53
@robyf70
Copy link
Contributor Author

robyf70 commented Apr 27, 2018

@pedrobaeza I've just pushed a new rebased patch with related pivot and graph views

@robyf70
Copy link
Contributor Author

robyf70 commented Apr 27, 2018

@pedrobaeza Sorry! Wrong patch, will resubmit

@robyf70 robyf70 force-pushed the 10.0-add_pivot_and_graph_view_to_account_due_list branch 2 times, most recently from 7984848 to d7cecb8 Compare April 27, 2018 15:07
@robyf70
Copy link
Contributor Author

robyf70 commented Apr 27, 2018

@pedrobaeza Now looks fine

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what about graph view?

<field name="context">{'search_default_from_invoices': 1}</field>
<field name="view_id" ref="view_payments_tree"/>
<field name="search_view_id" ref="view_payments_filter"/>
<field name="domain">[('account_id.internal_type', 'in', ['receivable', 'payable'])]</field>
</record>

<record model="ir.actions.act_window.view" id="view_payments_tree_action">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

<field name="act_window_id" ref="action_invoice_payments"/>
</record>

<record model="ir.actions.act_window.view" id="view_payments_pivot_action">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed.

@robyf70 robyf70 force-pushed the 10.0-add_pivot_and_graph_view_to_account_due_list branch from d7cecb8 to dbab2ec Compare April 27, 2018 16:01
@robyf70
Copy link
Contributor Author

robyf70 commented Apr 27, 2018

@pedrobaeza ok! I've done some changes and added the missing graph view, let me know if now looks ok for you

Copy link
Contributor

@adrienpeiffer adrienpeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza pedrobaeza merged commit 9cc05d0 into OCA:10.0 May 16, 2018
@pedrobaeza
Copy link
Member

Cherry-picked for v11 in b2addc3

eLBati pushed a commit to eLBati/account-payment that referenced this pull request Oct 29, 2018
MiquelRForgeFlow pushed a commit to ForgeFlow/account-payment that referenced this pull request Jan 29, 2020
SimoneVagile pushed a commit to SimoneVagile/account-payment that referenced this pull request Mar 30, 2021
LudLaf pushed a commit to Tecnativa/account-payment that referenced this pull request Apr 12, 2022
mileo pushed a commit to kmee/account-payment that referenced this pull request Oct 21, 2022
ramiadavid pushed a commit to ramiadavid/account-payment that referenced this pull request Oct 21, 2022
luisDIXMIT pushed a commit to dixmit/account-payment that referenced this pull request Mar 13, 2024
ramiadavid pushed a commit to ramiadavid/account-payment that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants