Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use designated labels in proposals to link to related issues & pull requests #1905

Closed
tedepstein opened this issue Apr 25, 2019 · 6 comments
Closed
Labels

Comments

@tedepstein
Copy link
Contributor

tedepstein commented Apr 25, 2019

PR #1868 introduces a new workflow for proposals. As described in my comment on that PR, I think proposals should evolve through discussion in multiple related issues and pull requests.

To manage this evolution more easily I suggest we create a designated GitHub label for each draft proposal. Apply that label to relevant issues and PRs. Specify that label towards the top of the draft proposal, followed by two links:

  1. Open issues related to the draft proposal (filtered by label)
  2. Open pull requests related to the draft proposal (filtered by label)
@tedepstein
Copy link
Contributor Author

We now seem to have an approach to this. A small group of community members has labeling privileges, so we can manage this. I'll go back to my proposal and put this to use now. Assuming it works nicely, I'll also submit a PR to update the proposal template.

@MikeRalphson
Copy link
Member

@tedepstein what changes to the proposals template did you have in mind?

@tedepstein
Copy link
Contributor Author

@MikeRalphson , this would be easier to illustrate if I could show an example, but that requires creating a new label. I can only apply labels, not create them. Could you create a new label called "Proposal: clarify-nullable" so I can show how this would work?

@tedepstein
Copy link
Contributor Author

tedepstein commented Jun 21, 2021

@MikeRalphson , to answer your question directly, I would suggest modifying the proposal template as shown here.

The proposal template would look like this.

@MikeRalphson
Copy link
Member

Looks good to me.

@handrews
Copy link
Member

@lornajane recently updated the proposals documentation -if there is still something needed here, please open an issue based on the current state of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants