-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc improvements: query formats (n/a usage, "rendering") #1663
Comments
@KES777 well, this depends on the target language and framework for which you generate the code from the OA specification. Or do you want to do that manually? |
I understand that as next:
Also I do not understand why it is called
|
You have to put that into context. Namely the configuration for the parameter, specifying the style and everything. This is what is shown by the table, of how request parameters will be rendered (internally, marshalled that is as a get request parameter), by the system. And yes, you are right, the documentation is somewhat misleading. So instead of |
Also I do not understand why there are these |
With I'm inclined to leave the "n/a"s for the other three even though they arguably ought to mimic |
@OAI/tsc review request: Am I missing anything with the n/a's? |
I think the n/a entries are correct and should remain unchanged. I vote for closing this issue without further action, unless someone wants to add a small clarification about what n/a means. |
Agreed in the TSC meeting that we can add a clarification to differentiate between "these two things in a row and column really don't go together" and "empty value" |
n/a's should be noted as [n/a] or just as [unsupported]. |
@silkentrance I've expanded PR #3859 (which already addressed the "rendering" part of this) with the remaining fixes. I went with n/a in italics to keep from making the table any wider than it already is. I added bullet points above the table explaining that n/a means the behavior is undefined, and that e/s (which replaced some old n/a entries) means "empty string". We'll see how that lands with folks... |
PR merged for 3.0.4 and ported to 3.1.1 via PR #3921! |
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.1.md#parameter-object-examples
Would it be more clear if an example of query url provided?
For an example, how url query should looks for this? How to repeat the parameter?
The text was updated successfully, but these errors were encountered: