Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need clarification on how to handle multiple OAuth scopes in an endpoint #1106

Closed
dclucas opened this issue May 16, 2017 · 3 comments
Closed
Milestone

Comments

@dclucas
Copy link

dclucas commented May 16, 2017

The specs make it very clear that in case of multiple security schemes are present in the spec, that should be read as a logical AND.

On the other hand, when describing the list of scopes within a scheme (see paste below), the text seems to imply a logical AND operation as well, without making it 100% explicit.

If the security scheme is of type "oauth2", then the value is a list of scope names required for the execution. For other security scheme types, the array MUST be empty.

So can we make it clear on the text whether those entries should be an "OR", "AND" or whether the specs imply no relationship whatsoever?

@webron
Copy link
Member

webron commented May 16, 2017

If it's a list of required scopes, it does mean AND. We can certainly improve the wording though.

@dclucas
Copy link
Author

dclucas commented May 17, 2017

Cool, tks. I will submit another issue against the new spec, to try to cover for scenarios where an "OR" would be required.
On the current text, more than happy to submit a PR to make this more explicit...

@webron
Copy link
Member

webron commented May 17, 2017

You're welcome to submit a PR to that effect. As for covering OR, keep in mind we are very close to finalizing this version of the spec, so I suggest you do it fast and we just might be able to squeeze it in. Would suggest that you add a suggestion to the construct itself, otherwise it's going to be a very slim chance it'll get in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants