Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README should be specific #188

Closed
MichalBryxi opened this issue Jan 2, 2022 · 2 comments
Closed

README should be specific #188

MichalBryxi opened this issue Jan 2, 2022 · 2 comments

Comments

@MichalBryxi
Copy link
Contributor

The paragraph:

XState provides its own matches
method which is available on the state object.
We can utilize this provided there exists a HelperManager for
handling vanilla functions, such as what
ember-could-get-used-to-this
provides.

Left me wondering what am I supposed to do? Install that addon? Install & configure something somewhere? What is HelperManger anyway? Why should I care?

Proposal:

  • Tell user what to do with a good default option
  • Explain in the notes why was this necessary
@NullVoxPopuli
Copy link
Owner

NullVoxPopuli commented Jan 3, 2022

I think you PR'd this?
and it's now merged?
can we close?

@MichalBryxi
Copy link
Contributor Author

My OSS skills be rusty. Solved in #189.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants