Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

PR description length may block merging #985

Closed
1 of 7 tasks
timmkrause opened this issue May 21, 2020 · 2 comments
Closed
1 of 7 tasks

PR description length may block merging #985

timmkrause opened this issue May 21, 2020 · 2 comments
Labels

Comments

@timmkrause
Copy link

🐛 Bug Report

NuKeeper may produce pretty large pull request descriptions.

We are reaching the limits of Azure DevOps regarding description length sometimes when merging PRs.

grafik

Side question: Is there a way to influence the description generation (or title generation)?

One way would be to add a limit for the maximum length which defaults to the currently allowed length by Azure DevOps and simply cut it from there and add [...] at the end of the description.

I can imagine (!= I know) that this may be a quick fix and a low hanging fruit. Later on an option may be introduced to configure this (e.g. --maxDescriptionLength {charCount/encodedLength}).

One can argue that it should be an active decision by the user if it gets cut or not as others want to decide on their own what should be in the description and what should not. Then the mentioned option would be the way to go.

Another alternative would be to influence the description generation in some way, maybe via a template file?

Expected behavior

Created pull requests should be mergable right away, at least via configuration.

Configuration

Version: 0.27.1

Platform if applicable:

  • 🛠️ NuKeeper CLI
  • ✨ GitHub
  • 🤖 AzureDevops
  • 🏁 Bitbucket
  • 🌎 Gitlab
  • 📺 Gitea
  • 🐳 Docker
@stale
Copy link

stale bot commented Aug 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 19, 2020
@stale stale bot closed this as completed Sep 9, 2020
@CrispyDrone
Copy link
Contributor

CrispyDrone commented Nov 23, 2020

A max length of 4000 has been present since at least version 0.20.1. I'm confused why this is not working for you.

Are you running a private instance? What version of Azure Devops (Server vs Services) are you on? Is it possible that somehow comments on the pull request will make the "description" longer than 4000? Can you confirm that the 4340 characters are used by only the pull request description?

I have a pull request open for customizing the templates for commit messages, pull request titles and bodies over here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants