Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet.org handling of tool packages #5182

Closed
1 of 2 tasks
nkolev92 opened this issue Dec 13, 2017 · 10 comments
Closed
1 of 2 tasks

NuGet.org handling of tool packages #5182

nkolev92 opened this issue Dec 13, 2017 · 10 comments

Comments

@nkolev92
Copy link
Member

nkolev92 commented Dec 13, 2017

As part of the global tools work, NuGet side spec, we will introduce a new package type.

The name of this package type is to be determined, I will update when that's done.

The 2 requests are the following:

  • NuGet.org should reject packages that include the global package tool and any other package type
  • Packages with this package type should display a “dotnet install packageId packageVersion” tab only, rather than the standard tabs.

This will need to be live in the 15.7 timeline of Visual Studio, potentially earlier tbd.

//cc
@rrelyea
@NuGet/nuget-client
@joelverhagen
@anangaur
@KathleenDollard

@wli3
Copy link

wli3 commented Mar 8, 2018

What is the statues on this issue? A MVP asked about toady. A tool package will show up as, in nuget.org

dotnet add package my.tool --version aVersion

@wli3
Copy link

wli3 commented Mar 8, 2018

mock up and this is wrong

image

@nkolev92
Copy link
Member Author

nkolev92 commented Mar 8, 2018

/cc
@skofman1 was this scheduled at some point?

@nkolev92 nkolev92 self-assigned this Mar 8, 2018
@nkolev92
Copy link
Member Author

nkolev92 commented Mar 8, 2018

It's a very small change server-side, I'll do some investigation within the next week or 2.

Does that work for you @wli3 ?

@maartenba
Copy link
Contributor

Any docs on the small server change?

@joelverhagen
Copy link
Member

Any docs on the small server change?

We will be using package type in the package .nuspec to toggle this behavior. Package types are currently persisted in our gallery DB. This is not a protocol change and only relates to gallery web UI behavior.

@maartenba
Copy link
Contributor

Got it. Asked because there is an issue that also talks about exposing this (even thing there is a PR for it on search service), hence.

@wli3
Copy link

wli3 commented Mar 8, 2018

the correct one should be

dotnet install tool --global my.tool --version 1.0.0
cc @KathleenDollard

@nkolev92
Copy link
Member Author

Verified fix on dev.
//cc @skofman1 @joelverhagen
dev-global tool

@nkolev92 nkolev92 added this to the S134 - 2018/04.09 milestone Apr 13, 2018
@loic-sharma
Copy link
Contributor

/cc @nkolev92 This is deployed to prod. I verified the dotnet watch tool: https://www.nuget.org/packages/dotnet-watch/2.1.0-preview1-final

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants