initial commit #1668
Merged
initial commit #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a bug for this? If not, can you create one? |
|
Looks good though, once it gets attached to a bug, I say |
|
issue #1669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1669
Added dots and hover to show exact number on line graph of downloads on statistics page.
The point of this is obviously the hover text - the dot gives you something to hover over.
For the hover text, toLocaleString() did not behave consistently on all the browsers (on IE it shows .00 ) so I resorted to d3.format which is not particularly localized (as far as I know) but is consistent with the axis formatting - so this is really a more correct solution
not sure we were tracking an issue for this one yet. fix is very simple and localized anyhow.
So far I've tested on Firefox, IE, Chrome and Opera