Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code obsoleted by Credentials table #1594

Closed
analogrelay opened this issue Sep 18, 2013 · 1 comment
Closed

Remove code obsoleted by Credentials table #1594

analogrelay opened this issue Sep 18, 2013 · 1 comment
Assignees
@analogrelay
Labels
Priority - 3
Milestone
I4 - 11/1 QA - 11...

Comments

@analogrelay
Copy link
Contributor

UserService.FindByApiKey/GenerateApiKey

Obsolete them as Error to find the instances of them. Replace them with calls to AuthenticateCredential and ReplaceCredential (+CredentialBuilder.CreateV1ApiKey) instead.

NOTE: Only do this if the database has been cleaned of all non-credential-based API Keys.

UserService.AuthenticatePassword

Stop looking at HashedPassword column. Again, verify database is clean of old passwords using worker job.

User

Remove HashedPassword and PasswordHashAlgorithm columns.
@ghost ghost assigned analogrelay Sep 18, 2013
@analogrelay analogrelay mentioned this issue Sep 23, 2013
Closed
@analogrelay
Copy link
Contributor Author

Will do this as part of #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@analogrelay analogrelay

Labels
Priority - 3
Projects
None yet
Milestone
I4 - 11/1 QA - 11/15 Production
Development

No branches or pull requests
1 participant
@analogrelay