Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Invalidate auth cookie after password change #1523

Closed
TimLovellSmith opened this issue Aug 23, 2013 · 5 comments
Closed

[Security] Invalidate auth cookie after password change #1523

TimLovellSmith opened this issue Aug 23, 2013 · 5 comments

Comments

@TimLovellSmith
Copy link
Member

From our bug bash -
Repro:
• Open edit package page in one browser
• In another browser, change the password of the same account
• Submit the changes from the first browser.
• Expected:
• It should reject the changes
• Actual:
• The changes applied.

@TimLovellSmith
Copy link
Member Author

I have thought about this one and I don't really like the idea of verify every authorization cookie check stateful against SQL or whatever. The nice thing about cookies is they are supposed to help keep your app stateless. There are some compromises possible, like force stateful validation for certain actions, like account management and package management...

@analogrelay
Copy link
Contributor

It's not that scary perf-wise if you instead say that every write operation performs a stateful SQL authorization cookie check, but that read operations just trust the signed cookie. Though that is a heavier work item.

@ghost ghost assigned analogrelay Sep 10, 2013
@analogrelay
Copy link
Contributor

Let me take a quick look and see if we can do it without checking SQL all the time.

@analogrelay
Copy link
Contributor

I'll roll this in to some credential work I'm doing:

  1. Persistent cookie based on a token derived from the password (hash, etc.)
  2. Temporary session cookie which can be automatically refreshed from the persistent cookie and is NOT password-dependent.

@skofman1
Copy link
Contributor

We deprecated password auth.

@skofman1 skofman1 removed this from the Up For Grabs milestone Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants