-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security] Invalidate auth cookie after password change #1523
Comments
I have thought about this one and I don't really like the idea of verify every authorization cookie check stateful against SQL or whatever. The nice thing about cookies is they are supposed to help keep your app stateless. There are some compromises possible, like force stateful validation for certain actions, like account management and package management... |
It's not that scary perf-wise if you instead say that every write operation performs a stateful SQL authorization cookie check, but that read operations just trust the signed cookie. Though that is a heavier work item. |
Let me take a quick look and see if we can do it without checking SQL all the time. |
I'll roll this in to some credential work I'm doing:
|
We deprecated password auth. |
From our bug bash -
Repro:
• Open edit package page in one browser
• In another browser, change the password of the same account
• Submit the changes from the first browser.
• Expected:
• It should reject the changes
• Actual:
• The changes applied.
The text was updated successfully, but these errors were encountered: