Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore should support multiple project files targeting same baseintermediateobjdir #4850

Closed
niemyjski opened this issue Mar 20, 2017 · 1 comment
Labels
Functionality:Restore Priority:2 Issues for the current backlog. Resolution:Duplicate This issue appears to be a Duplicate of another issue Type:DCR Design Change Request
Milestone

Comments

@niemyjski
Copy link

I'm running the latest VS2017 release and dotnet 1.0.0 on windows 10 x64 stable. I came across a potential bug with dotnet restore.

Here is the a link the source:
https://github.com/exceptionless/Exceptionless.Net/tree/9614d2bc1d2cb949945d05ff4dbf0d8bed0738f0

I have to have signed nuget packages so my initial goal was to have my shared library have a project.csproj and a project.signed.csproj in the same folder. Then in depending packages (projectc) have a msbuild condition based on the state of SignAssembly and reference the correct csproj file and set the new package id. This failed because dotnet restore creates the lock file without signing. So when I build projectc it works, when I do a second pass on projectc with a msbuild property set to enable signing it would compile the first signed target framework and then blow up with a crazy error. I have sense abandoned this approach and went for a new csproj and folder per signed project as I couldn't get around this.. I no longer have the error message but it should be simple to reproduce.

@rrelyea rrelyea added this to the 4.3 milestone Mar 20, 2017
@rrelyea rrelyea added the Type:DCR Design Change Request label Mar 20, 2017
@rrelyea rrelyea changed the title dotnet restore doesn't work correctly if your csproj has conditional dependencies. restore should support multiple project files targeting same baseintermediateobjdir Mar 20, 2017
@rrelyea rrelyea modified the milestones: 4.4, 4.3 Jun 26, 2017
@emgarten emgarten modified the milestones: 4.4, Backlog Oct 17, 2017
@emgarten emgarten added Priority:2 Issues for the current backlog. and removed 0 - Backlog labels Oct 17, 2017
@nkolev92
Copy link
Member

nkolev92 commented Feb 4, 2020

Duplicate of #4463

@nkolev92 nkolev92 marked this as a duplicate of #4463 Feb 4, 2020
@nkolev92 nkolev92 closed this as completed Feb 4, 2020
@nkolev92 nkolev92 added Resolution:Duplicate This issue appears to be a Duplicate of another issue and removed ToBeMoved labels Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Restore Priority:2 Issues for the current backlog. Resolution:Duplicate This issue appears to be a Duplicate of another issue Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

4 participants