Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version is not honored between p2p refs during 'pack' and 1.0.0 gets embedded #4508

Closed
attilah opened this issue Feb 5, 2017 · 5 comments
Closed
Labels
Functionality:Pack Resolution:Duplicate This issue appears to be a Duplicate of another issue Triage:Investigate
Milestone

Comments

@attilah
Copy link

attilah commented Feb 5, 2017

Details about Problem

If you've ProjectA and ProjectB where ProjectB refs ProjectA with a P2P ref and you're specifying Version on the commandline, then this will be in the ProjectB.nuspec:

<dependency id="ProjectA" version="1.0.0" exclude="Build,Analyzers" />

The version in nupkg filename and within nuspec files for the packages themselves are good!

@rohit21agrawal
Copy link
Contributor

details about what version of nuget you are using would be appreciated along with a repro project

@attilah
Copy link
Author

attilah commented Feb 6, 2017

I tried with VS2017 RC3 bundled tools, but now on my work machine I've:

These:

dotnet nuget --version
NuGet Command Line
4.0.0.0

dotnet --version
1.0.0-rc4-004755

For some reason I'm not able to attach the repro zip to this issue, sending it you internally in mail.

I get this message: "We don’t support that file type. Choose Files Try again with a PNG, GIF, JPG, DOCX, PPTX, XLSX, TXT, PDF, or ZIP."

@rrelyea
Copy link
Contributor

rrelyea commented Feb 6, 2017

Believe this is a dupe of this issue: #3901
That issue is already fixed...and will show up in the next update.

@rrelyea rrelyea added this to the 4.0 RC4 milestone Feb 6, 2017
@rohit21agrawal
Copy link
Contributor

it should not happen for command line scenarios in the first place..i'll try using both VS and command-line and see where we are at

@rrelyea rrelyea modified the milestones: 4.0 RTM, 4.0 RC4 Feb 7, 2017
@rohit21agrawal
Copy link
Contributor

verified using both command line and VS, seems to be fixed. closing the issue.

@attilah if you see this in any build of VS less than 2 days old, please reactive this issue.

@DoRonMotter DoRonMotter added the Resolution:Duplicate This issue appears to be a Duplicate of another issue label Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Pack Resolution:Duplicate This issue appears to be a Duplicate of another issue Triage:Investigate
Projects
None yet
Development

No branches or pull requests

4 participants