Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DCR]: NuGet-based MSBuild project SDK resolver should run after .NET SDK resolver #11566

Closed
jeffkl opened this issue Feb 4, 2022 · 1 comment · Fixed by NuGet/NuGet.Client#4443
Closed

[DCR]: NuGet-based MSBuild project SDK resolver should run after .NET SDK resolver #11566

jeffkl opened this issue Feb 4, 2022 · 1 comment · Fixed by NuGet/NuGet.Client#4443
Assignees
@jeffkl
Labels
Priority:2 Issues for the current backlog. Product:MSBuildSDKResolver The NuGet powered SDK resolver. Owned by MSBuild team Type:DCR Design Change Request
Milestone
Sprint 2022-02

Comments

@jeffkl
Copy link
Contributor

jeffkl commented Feb 4, 2022

NuGet Product(s) Affected

NuGet.exe, MSBuild.exe, dotnet.exe

Current Behavior

Currently the NuGet-based MSBuild project SDK resolver runs before the .NET SDK resolver. The intention was that a user could override built-in SDKs with their own or we could ship official SDKs as NuGet packages. However, after years of this SDK infrastructure being available, it is extremely unlikely we'll be changing how SDKs are shipped.

Desired Behavior

Instead, we should make the NuGet-based MSBuild project SDK resolver run after the .NET SDK resolver so that if a user is using a built-in SDK like Microsoft.NET.Sdk then its resolved faster. There is a bit of overhead with the NuGet-based MSBuild project SDK resolver so avoiding it when we know the SDK is just built-in is a win for customers.

Additional Context

No response
@jeffkl jeffkl added Priority:2 Issues for the current backlog. Type:DCR Design Change Request Product:MSBuildSDKResolver The NuGet powered SDK resolver. Owned by MSBuild team Pipeline:Backlog Triage:Untriaged labels Feb 4, 2022
@jeffkl jeffkl self-assigned this Feb 4, 2022
@jeffkl jeffkl modified the milestones: Sprint 2022-01, Sprint 2022-02 Feb 4, 2022
@jeffkl jeffkl mentioned this issue Feb 4, 2022
Open
18 tasks
@jeffkl
Copy link
Contributor Author

jeffkl commented Feb 4, 2022 •
edited
Loading

Related to #11443
Epic: #11441

@jeffkl jeffkl mentioned this issue Feb 4, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffkl jeffkl

Labels
Priority:2 Issues for the current backlog. Product:MSBuildSDKResolver The NuGet powered SDK resolver. Owned by MSBuild team Type:DCR Design Change Request
Projects
None yet
Milestone
Sprint 2022-02
2 participants
@nkolev92 @jeffkl