Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log handlers to more generic event listener #5

Open
andyday opened this issue Jan 24, 2017 · 0 comments
Open

Change log handlers to more generic event listener #5

andyday opened this issue Jan 24, 2017 · 0 comments
Assignees

Comments

@andyday
Copy link
Contributor

andyday commented Jan 24, 2017

change opts.log to opts.events with the same functions. also change all refs to log or logs to event or events. each function (ie send, send, etc) should change arg opts to event or e. Also we should include at least the following on the event

{
    request:  {}, // request-promise request object minus any internal properties (or possible recursion)
    response:  {}, request-promise response object minus any internal properties (or possible recursion) (this will only have a value on sent, and error)
    startedAt:  209320982324,  // replaces timestamp
    duration:  2933,  // time spent sending  (only included on sent or error)
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants