Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Network parameters improvements #523

Merged
merged 11 commits into from
Jun 14, 2023
Merged

Breaking: Network parameters improvements #523

merged 11 commits into from
Jun 14, 2023

Conversation

philips77
Copy link
Member

This PR externalizes the network parameters from MeshNetworkManager to separate structure NetworkParameters.

Migration guide

Old code

meshNetworkManager = MeshNetworkManager()
meshNetworkManager.acknowledgmentTimerInterval = ...
meshNetworkManager.transmissionTimerInterval = ...
meshNetworkManager.incompleteMessageTimeout = ...
meshNetworkManager.retransmissionLimit = ..
meshNetworkManager.acknowledgmentMessageInterval = ...
meshNetworkManager.acknowledgmentMessageTimeout = ...

New code

meshNetworkManager.networkParameters = .custom { builder in
    builder.acknowledgmentTimerInterval = ...
    builder.transmissionTimerInterval = ...
    builder.incompleteMessageTimeout = ...
    builder.retransmissionLimit = ...
    builder.acknowledgmentMessageInterval = ...
    builder.acknowledgmentMessageTimeout = ...
}

@philips77 philips77 merged commit bfa2a32 into main Jun 14, 2023
@philips77 philips77 deleted the network-params branch June 14, 2023 10:27
@philips77
Copy link
Member Author

The API of NetworkParameters was modified in #555.

@philips77 philips77 mentioned this pull request Oct 10, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant