Add support for Scheduler messages #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a slightly more abstract way of reading bits from a packed structure.
philips77
approved these changes
Sep 13, 2022
| public let dayOfWeek: SchedulerDayOfWeek | ||
| public let action: SchedulerAction | ||
| public let transitionTime: TransitionTime | ||
| public let sceneNumber: UInt16 |
There was a problem hiding this comment.
Could you use Scene type for scene? That's an alias for UInt16, but can be more readable.
| sceneNumber = 0 | ||
| } | ||
|
|
||
| public init(year: SchedulerYear, month: SchedulerMonth, day: SchedulerDay, hour: SchedulerHour, minute: SchedulerMinute, second: SchedulerSecond, dayOfWeek: SchedulerDayOfWeek, action: SchedulerAction, transitionTime: TransitionTime, sceneNumber: UInt16) { |
| let transitionTime = TransitionTime(rawValue: parameters[7]) | ||
| let sceneNumber: UInt16 = parameters.read(fromOffset: 8) | ||
|
|
||
| return (index, SchedulerRegistryEntry(year: SchedulerYear(value: year), month: SchedulerMonth(value: month), day: SchedulerDay(value: day), hour: SchedulerHour(value: hour), minute: SchedulerMinute(value: minute), second: SchedulerSecond(value: second), dayOfWeek: SchedulerDayOfWeek(value: dayOfWeek), action: SchedulerAction(rawValue: action)!, transitionTime: transitionTime, sceneNumber: sceneNumber)) |
philips77
approved these changes
Sep 14, 2022
|
Great work, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual, not tested live, but unit tests are written using data extracted from Android SDK which has been tested live.
Have a look at my attempt to make reading and writing the structures that are "packed" from the mesh protocol and see what you think. This could be used on the Time messages as well if it's good enough.