Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration from ButterKnife to View Bindings #45

Merged
merged 7 commits into from
Apr 23, 2021
Merged

Migration from ButterKnife to View Bindings #45

merged 7 commits into from
Apr 23, 2021

Conversation

philips77
Copy link
Member

This PR migrates UI to ViewBindings as ButterKnife was deprecated.

roshanrajaratnam
roshanrajaratnam reviewed Apr 23, 2021
View reviewed changes
Copy link
Member

@roshanrajaratnam roshanrajaratnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor feedback would be to set an id to the parent layout within the included layout to avoid using getRoot(). This is only minor though!

@philips77
Copy link
Member Author

I like your suggestion!

@philips77 philips77 changed the base branch from develop to master April 23, 2021 13:30
@philips77 philips77 changed the base branch from master to develop April 23, 2021 13:30
@philips77 philips77 merged commit 53b5e39 into develop Apr 23, 2021
@philips77 philips77 deleted the migration/view-bindings branch April 23, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roshanrajaratnam roshanrajaratnam roshanrajaratnam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philips77 @roshanrajaratnam