Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for plotting #52

Closed
oameye opened this issue Oct 7, 2022 · 2 comments
Closed

Tests for plotting #52

oameye opened this issue Oct 7, 2022 · 2 comments
Assignees
Labels
new feature New feature or request plotting Related to the plotting functionality of the package

Comments

@oameye
Copy link
Member

oameye commented Oct 7, 2022

As the recent update showed it could be handy to have some testing function for the plotting capabilities of HarmonicBalance. However, not sure how to test plotting other than testing if the plot funtion run.

@oameye oameye changed the title Test for plotting Tests for plotting Oct 7, 2022
@jkosata jkosata added new feature New feature or request plotting Related to the plotting functionality of the package labels Oct 7, 2022
@oameye
Copy link
Member Author

oameye commented Nov 13, 2022

So one can test the plot functionality by using VisualRegressionTests.jl of the Plots.jl ecosystem. If I understand correctly, one can use the package to test without adding it to the dependencies by adding it to extras in the project.toml file. @jkosata Can you confirm?

Sources:

@oameye
Copy link
Member Author

oameye commented Jan 2, 2023

So I actually think this is maybe a bit of an overkill 😛. I think the basic running test that were implemented in #88 are enough for a package of our scale.

@oameye oameye closed this as completed Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request plotting Related to the plotting functionality of the package
Projects
None yet
Development

No branches or pull requests

2 participants