Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make method structs #204

Closed
oameye opened this issue Jul 19, 2024 · 1 comment · Fixed by #298
Closed

Make method structs #204

oameye opened this issue Jul 19, 2024 · 1 comment · Fixed by #298
Labels
Breaking good first issue Good for newcomers new feature New feature or request

Comments

@oameye
Copy link
Member

oameye commented Jul 19, 2024

Instead of method=:total_degree, we should make method structs that can be called like TotalDegree(; kwargs...). This allows to give options to the Homotopy solvers

@oameye oameye added new feature New feature or request Breaking good first issue Good for newcomers labels Oct 26, 2024
@oameye oameye mentioned this issue Oct 27, 2024
4 tasks
@jkosata
Copy link
Member

jkosata commented Nov 3, 2024

This makes sense but now the portion of the code that could be classified as "convenience functions for HomotopyContinuation" is getting pretty big.

In retrospect, I think this would have made sense as a separate small package rather than being entangled with HB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking good first issue Good for newcomers new feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants