fix: Only allow an identifier in the Yul variable declaration position #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Yul identifiers could have dots in the name but that's not the case starting from 0.7. As such, we need to disallow these forms for the variable declaration and instead only accept the identifier, as is done by the upstream grammar.
🦋 Changeset detectedLatest commit: 25eacd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Xanewok
commented
Apr 25, 2024
| # This file is generated automatically by infrastructure scripts. Please don't edit by hand. | ||
|
|
||
| Source: > | ||
| 1 │ let a.b.c := 1 │ 0..14 |
There was a problem hiding this comment.
I've tested with dissect and we now exactly match this case with solc: this was allowed since 0.5.8 until 0.7, where we started disallowing dots in user-defined identifiers.
OmarTawfik
approved these changes
Apr 25, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @nomicfoundation/[email protected] ### Patch Changes - [#948](#948) [`ce88cb7`](ce88cb7) Thanks [@Xanewok](https://github.com/Xanewok)! - Restrict the grammar to correctly only allow an identifier in Yul variable declaration - [#945](#945) [`e8f80d8`](e8f80d8) Thanks [@Xanewok](https://github.com/Xanewok)! - Support `.address` built-in access in Yul paths Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Yul identifiers could have dots in the name but that's not the case starting from 0.7. As such, we need to disallow these forms for the variable declaration and instead only accept the identifier, as is done by the upstream grammar.
Thanks @OmarTawfik for finding this!