Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up precedence parser codegen since DSL v2 #699

Merged
merged 18 commits into from
Dec 9, 2023
Merged

Clean up precedence parser codegen since DSL v2 #699

merged 18 commits into from
Dec 9, 2023

Commits on Dec 8, 2023

  1. Remove ProductionKind in favor of RuleKind

    @Xanewok
    Xanewok committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    1f1468b View commit details
    Browse the repository at this point in the history

  2. Remove PrecedenceExpression::rule_name in favor of using its name 

    This introduced individual rule kinds per each precedence expression and
we lose the grouping rules such as BinaryExpression. Not sure how
desirable they were in the first place but it seems better and easier to
handle specific expressions rather than using grouping rule kinds like
before.
    @Xanewok
    Xanewok committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    1bbb2d5 View commit details
    Browse the repository at this point in the history

  3. refactor: Move disambiguating_name_suffix to precedence-related code 

    Since it's the only place it's used and it's a small helper.
    @Xanewok
    Xanewok committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b3e7c16 View commit details
    Browse the repository at this point in the history

  4. refactor: Simplify redundant Option-wrapping in precedence codegen

    @Xanewok
    Xanewok committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f877ec6 View commit details
    Browse the repository at this point in the history

  5. Factor out parser helpers from precedence codegen function

    @Xanewok
    Xanewok committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    65e2a26 View commit details
    Browse the repository at this point in the history

  6. refactor: Simplify emitted prefix/postfix parser helpers

    @Xanewok
    Xanewok committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    eddd9ae View commit details
    Browse the repository at this point in the history

  7. Add some comments to the precedence parser codegen

    @Xanewok
    Xanewok committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    0293980 View commit details
    Browse the repository at this point in the history

  8. Deduplicate the precedence operator parser functions 

    This also fixes a run-time regression introduced with duplicate operator
parsers when migrating to v2.

To support different associativity/models for precedence expressions
across multiple versions, the parser generator now:
- groups the operators by model for a given precedence expression
- defines a sub-parser for (expression, model) as a choice over the
  operators with a given model
- each of the precedence sub-parses reduces to the parent precedence
  expression rule kind.
    @Xanewok
    Xanewok committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    49acebb View commit details
    Browse the repository at this point in the history

  9. Allow parsing precedence expressions in our public API 

    This lets us completely get rid of the ProductionKind, as we support
parsing every `RuleKind` now.
    @Xanewok
    Xanewok committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    9f0add6 View commit details
    Browse the repository at this point in the history

  10. Add a unit test for the precedence expression parsers

    @Xanewok
    Xanewok committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    0296bef View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Simplify extract_version_pragmas with new precedence expr kinds

    @Xanewok
    Xanewok committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    137a1df View commit details
    Browse the repository at this point in the history

  2. Limit choice node wrapping for precedence expression op parsers

    @Xanewok
    Xanewok committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    c4dd9db View commit details
    Browse the repository at this point in the history

  3. Add changeset files

    @Xanewok
    Xanewok committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    b5c14bc View commit details
    Browse the repository at this point in the history

  4. Update breezy-otters-heal.md 

    Co-authored-by: Omar Tawfik <[email protected]>
    @Xanewok @OmarTawfik
    Xanewok and OmarTawfik authored Dec 9, 2023
    Configuration menu
    Copy the full SHA
    1ed286f View commit details
    Browse the repository at this point in the history

  5. Move conditional and exponentiation exprs into a dedicated CST parser… 

    … test
    @Xanewok
    Xanewok committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    fe12dd3 View commit details
    Browse the repository at this point in the history

  6. Revert "Add a unit test for the precedence expression parsers" 

    This reverts commit 0296bef.
    @Xanewok
    Xanewok committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    3da8aee View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into precedence-cleanup

    @Xanewok
    Xanewok committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    af09120 View commit details
    Browse the repository at this point in the history

  8. fixup: Fix formatting

    @Xanewok
    Xanewok committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    04a6e59 View commit details
    Browse the repository at this point in the history