Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit the 'create' method in HardhatEthersSigner #5796

Open
ChristopherDedominici opened this issue Oct 2, 2024 · 0 comments
Open

Revisit the 'create' method in HardhatEthersSigner #5796

ChristopherDedominici opened this issue Oct 2, 2024 · 0 comments
Assignees
@ChristopherDedominici
Labels
type:improvement v-next A Hardhat v3 development task

Comments

@ChristopherDedominici
Copy link
Contributor

ChristopherDedominici commented Oct 2, 2024 •
edited
Loading

The public method create in HardhatEthersSigner should be revisit.

TODOs:

  • networkName === "hardhat" now will be netorkConfig.type !== "http"
  • will blockGasLimit be supported in networkConfig? If so, it should be adapted

NOTE:
This issue might also be related to the extenders for AutomaticGasPriceProvider, see here
@ChristopherDedominici ChristopherDedominici added the v-next A Hardhat v3 development task label Oct 2, 2024
@ChristopherDedominici ChristopherDedominici self-assigned this Oct 2, 2024
Merged
@ChristopherDedominici ChristopherDedominici changed the title Revisit the creation of HardhatEthersSigner Revisit the 'create' method in HardhatEthersSigner Oct 2, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristopherDedominici ChristopherDedominici

Labels
type:improvement v-next A Hardhat v3 development task
Projects
Hardhat
Status: To-do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kanej @ChristopherDedominici