You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When disableByFlipClick is true, flipNext() has no effect; and flipToPage(pagenum) does nothing when the pagenum > currentpage.
Why? Because at line 245 of Flip.ts, the flipNext method simulates a lick at the right edge (top or bottom) of the displayRect and calls .flip(). But at line 80 of Flip.ts, only when disableFlipByClick is true, there is a test to see if the point passed in is within the display bounds; which fails because the x value is NOT strictly less than the displayWidth (it's equal to it).
I don't have the rig set up to recompile and test TypeScript so I won't post a pull request, but the fix is to edit line 245 of Flip.ts so that the x value passed in is a few pxiels less than the displayWidth; e.g. edit line 245 of Flip.ts to read:
When disableByFlipClick is true, flipNext() has no effect; and flipToPage(pagenum) does nothing when the pagenum > currentpage.
Why? Because at line 245 of Flip.ts, the flipNext method simulates a lick at the right edge (top or bottom) of the displayRect and calls .flip(). But at line 80 of Flip.ts, only when disableFlipByClick is true, there is a test to see if the point passed in is within the display bounds; which fails because the x value is NOT strictly less than the displayWidth (it's equal to it).
I don't have the rig set up to recompile and test TypeScript so I won't post a pull request, but the fix is to edit line 245 of Flip.ts so that the x value passed in is a few pxiels less than the displayWidth; e.g. edit line 245 of Flip.ts to read:
and that fixes both flipNext() and flipToPage. (In my case, I just monkey-patched it.) Hope that helps!
The text was updated successfully, but these errors were encountered: