Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] aggregate doesn't work correctly with most recent version of the code #224

Closed
iamyihwa opened this issue Jul 20, 2023 · 1 comment · Fixed by #232
Closed

[utils] aggregate doesn't work correctly with most recent version of the code #224

iamyihwa opened this issue Jul 20, 2023 · 1 comment · Fixed by #232
Labels

Comments

@iamyihwa
Copy link

What happened + What you expected to happen

Hi,
Thanks for adding sparse versions of the reconcile methods and S matrix.
aggregate() function however doesn't seem to work correctly. It doesn't seem to do the balancing (numpy_balance), and neither creating the aggregated time series based on spec.

pip version: (previous version)
image

main branch:
image

Versions / Dependencies

main branch

Reproduction script

Code to reproduce the result :

df = pd.DataFrame(data = {'cat1': ['a', 'a', 'a'], 'cat2': ['1', '2', '3'],
                         'y': [10, 20, 30], 'ds': ['2020-01-01', '2020-02-01', '2020-03-01']})
df.insert(0, 'country', 'COUNTRY')

spec = [['country'], ['country', 'cat1'], ['country','cat1', 'cat2']]

Y_df, S_df, tags = aggregate(df, spec)
Y_df

Issue Severity

None

@iamyihwa iamyihwa added the bug label Jul 20, 2023
@candalfigomoro
Copy link

Related issue #211 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants