Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strictly hierarchical assertions preceding fit method #138

Open
kdgutier opened this issue Dec 17, 2022 · 1 comment
Open

Strictly hierarchical assertions preceding fit method #138

kdgutier opened this issue Dec 17, 2022 · 1 comment
Assignees
@elephaint
Labels
enhancement

Comments

@kdgutier
Copy link
Collaborator

  • Deprecates pandas tags leaving pure numpy in methods.py and probabilistic_methods.py
  • Saves unnecesary computation to failed run after some fit time spent.
@elephaint
Copy link
Contributor

First is in place.

Second we could add a class attribute IS_STRICTLY_HIERARCHICAL that can be checked in reconcile, but it's a minor thing imho (in time).

@elephaint elephaint self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elephaint elephaint

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kdgutier @elephaint