Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magic-vlsi: 8.3.497 -> 8.3.501 #359323

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

fedeinthemix
Copy link
Contributor

Fixes issue #359320

./result/bin/magic -dnull -noconsole

Magic 8.3 revision 501 - Compiled on Tue Nov 26 16:01:52 UTC 2024.
Starting magic under Tcl interpreter
Using the terminal as the console.
Using NULL graphics device.
Processing system .magicrc file
Using technology "minimum", version 0.0
% 

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@thoughtpolice @AndersonTorres

ZHF: #352882


Add a 👍 reaction to pull requests you find important.

Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 26, 2024
@ofborg ofborg bot requested a review from thoughtpolice November 27, 2024 11:03
@thoughtpolice thoughtpolice merged commit 3f8feb8 into NixOS:master Nov 27, 2024
38 of 39 checks passed
@fedeinthemix fedeinthemix added the backport release-24.11 Backport PR automatically label Nov 27, 2024
Copy link
Contributor

Successfully created backport PR for release-24.11:

@fedeinthemix
Copy link
Contributor Author

I'd like to have the fix in 24.11

@fedeinthemix fedeinthemix deleted the fix-magic-vlsi branch November 28, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants