Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtk: switch to new sdk pattern on darwin #358790

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

tricktron
Copy link
Member

@tricktron tricktron commented Nov 24, 2024

Things done

Switch vtk to the sdk-pattern on darwin. The main reason was to fix gdcm as part of ZHF which it does.

However, this might break other packages, so a thorough review is needed.

Needs 24.11 backport for ZHF #ZurichZHF

ZHF: #352882

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tricktron tricktron added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign backport release-24.11 Backport PR automatically labels Nov 24, 2024
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 25, 2024
@wegank wegank force-pushed the switch-vtk-to-new-sdk-pattern branch from 6e60b1d to 71fbdd8 Compare November 25, 2024 20:57
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely clean‐up, thank you!

@tricktron
Copy link
Member Author

@wegank Thank you for stepping in and cleaning up the last bit!

@ofborg ofborg bot requested review from tfmoraes and knedlsepp November 26, 2024 16:41
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 26, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 26, 2024
@wegank wegank merged commit 8b9c050 into NixOS:master Nov 26, 2024
36 of 37 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants