python3Packages.accelerate: Bump version 1.0.0 -> 1.1.0 and fix few things #353184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add huggingface-hub to the dependencies, this should fix various import errors. Signed-off-by: Mika Tammi <[email protected]>
Signed-off-by: Mika Tammi <[email protected]>
darwin: Disable some tests, which started failing after enabling MPS in pytorch package. Signed-off-by: Mika Tammi <[email protected]>
13 tasks
|
Here's log of accelerate tests failing, before I disabled the failing tests: |
dotlambda
reviewed
Nov 2, 2024
|
Two questions i'm mostly concerned about:
|
|
Ideally yes. You can try re-enabling them all and adding them back only if needed.
Also yes, if the failures are not due to our testing setup (example, no need to report tests that are failing because of lacking internet access). |
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python3Packages.accelerate
Changelog can be found here: https://github.com/huggingface/accelerate/releases
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Tested some of the basic functionality.
I tested that now running binaries don't give straight ImportError about missing huggingface-hub anymore, but didn't test the functionality otherwise than trying to run binaries does print out --help to the terminal. I'm able to use accelerate in my own Python code whch runs StableDiffusion.
Add a 👍 reaction to pull requests you find important.