Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/srcOnly: init #347548

Merged
merged 1 commit into from
Nov 1, 2024
Merged

tests/srcOnly: init #347548

merged 1 commit into from
Nov 1, 2024

Conversation

Pandapip1
Copy link
Contributor

Adds a basic test to ensure that srcOnly functions correctly.

This is the first NixOS test I've written, and it's likely I've misunderstood something. If so, please let me know what's wrong and needs fixing!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Oct 9, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 9, 2024
Artturin
Artturin reviewed Oct 9, 2024
View reviewed changes
nixos/tests/all-tests.nix Outdated Show resolved Hide resolved
@Pandapip1 Pandapip1 marked this pull request as draft October 10, 2024 20:05
@github-actions github-actions bot removed the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Oct 10, 2024
@Pandapip1 Pandapip1 marked this pull request as ready for review October 10, 2024 20:20
@nix-owners nix-owners bot requested a review from philiptaron October 10, 2024 20:21
@Pandapip1 Pandapip1 requested a review from Artturin October 10, 2024 20:40
@Pandapip1
Copy link
Contributor Author

Why are there 0 rebuilds? Shouldn't the test be built by ofborg?

@philiptaron
Copy link
Contributor

Why are there 0 rebuilds? Shouldn't the test be built by ofborg?

ofBorg says there are eval failures: https://gist.github.com/GrahamcOfBorg/c66cf99db8083d357a67de3e66fbff9b

@Pandapip1
Copy link
Contributor Author

I swear that wasn't there :|

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 12, 2024
@philiptaron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 347548

x86_64-linux

✅ 1 package built:
  • tests.srcOnly

philiptaron
philiptaron approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@philiptaron philiptaron merged commit 8d9fcbc into NixOS:master Nov 1, 2024
27 checks passed
@Pandapip1 Pandapip1 deleted the srcOnly-tests branch November 1, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philiptaron philiptaron philiptaron approved these changes

@Artturin Artturin Awaiting requested review from Artturin

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pandapip1 @philiptaron @Artturin