Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jellyfin-media-player: fix build on Darwin #346952

Merged
merged 1 commit into from
Oct 11, 2024
Merged

jellyfin-media-player: fix build on Darwin #346952

merged 1 commit into from
Oct 11, 2024

Conversation

reckenrode
Copy link
Contributor

  • Stop removing web resources (it no longer seems necessary); and
  • Enable aarch64-darwin

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@reckenrode reckenrode mentioned this pull request Oct 6, 2024
Merged
52 tasks
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package labels Oct 6, 2024
@ofborg ofborg bot requested review from Kranzes and jojosch October 6, 2024 23:27
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 6, 2024
@reckenrode reckenrode force-pushed the push-qpvmuoqqwzkk branch 2 times, most recently from 95acb78 to 24b6e81 Compare October 8, 2024 02:56
@reckenrode
jellyfin-media-player: fix build on Darwin
8bf3d7c 
- Stop removing web resources (it no longer seems necessary); and
- Enable aarch64-darwin
@emilazy emilazy merged commit e8c2e6f into NixOS:master Oct 11, 2024
26 checks passed
@reckenrode reckenrode deleted the push-qpvmuoqqwzkk branch October 11, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

@Kranzes Kranzes Awaiting requested review from Kranzes

@jojosch jojosch Awaiting requested review from jojosch

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reckenrode @emilazy