Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memstream: cross-compilation fixes #346934

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

reckenrode
Copy link
Contributor

Tested with Darwin to Darwin cross-compilation using #346043. Targeting staging due to rebuilds (cctools).

  • Use $(CC) to pick up the prefixed compiler automatically; and
  • Only run check phase when the builder can execute host binaries.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild labels Oct 6, 2024
@ofborg ofborg bot requested a review from veprbl October 6, 2024 23:01
- Use `$(CC)` to pick up the prefixed compiler automatically; and
- Only run check phase when the builder can execute host binaries.
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 7, 2024
@veprbl veprbl merged commit bdff2c4 into NixOS:staging Oct 7, 2024
26 of 27 checks passed
@reckenrode reckenrode deleted the push-spxzyywvsqvs branch October 8, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants