Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: suppress failing test on x86_64-darwin #346877

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

reckenrode
Copy link
Contributor

I encountered this issue while working on #346043. nodejs22 is also failing to build on staging-next #343421 with the same error. This may be a Rosetta 2 issue on macOS 15. It doesn’t happen with a native build on aarch64-darwin.

not ok 3848 pummel/test-vm-memleak
  ---
  duration_ms: 3955.65700
  severity: fail
  exitcode: 1
  stack: |-
    node:internal/assert/utils:281
        throw err;
        ^
    
    AssertionError [ERR_ASSERTION]: memory usage: 75493376 baseline: 41930752
        at Timeout._onTimeout (/private/tmp/nix-build-nodejs-22.9.0.drv-0/node-v22.9.0/test/pummel/test-vm-memleak.js:47:10)
        at listOnTimeout (node:internal/timers:594:17)
        at process.processTimers (node:internal/timers:529:7) {
      generatedMessage: false,
      code: 'ERR_ASSERTION',
      actual: false,
      expected: true,
      operator: '=='
    }
    
    Node.js v22.9.0
  ...

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 6, 2024
@reckenrode
Copy link
Contributor Author

Pinging @aduh95 to review per @emilazy.

@ofborg ofborg bot requested a review from aduh95 October 6, 2024 14:35
@ofborg ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 501-1000 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 6, 2024
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why that’s happening now, skipping the tests certainly fine by me though

@emilazy emilazy merged commit 41bc722 into NixOS:staging-next Oct 6, 2024
29 of 30 checks passed
@reckenrode reckenrode deleted the push-nvlywxtmkwkv branch October 7, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: nodejs 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants