Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby: 3.3.4 -> 3.3.5 #340137

Merged
merged 1 commit into from
Sep 7, 2024
Merged

ruby: 3.3.4 -> 3.3.5 #340137

merged 1 commit into from
Sep 7, 2024

Conversation

stahnma
Copy link
Contributor

@stahnma stahnma commented Sep 6, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@stahnma stahnma changed the title update: Ruby to 3_3_5 ruby: 3.3.4 -> 3.3.5 Sep 6, 2024
@tomberek tomberek added the backport release-24.05 Backport PR automatically label Sep 6, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Sep 6, 2024
@alyssais
Copy link
Member

alyssais commented Sep 6, 2024

Please follow the commit message conventions documented in CONTRIBUTING.md.

@alyssais
Copy link
Member

alyssais commented Sep 6, 2024

CVE-2024-43398
CVE-2024-41946
CVE-2024-41123
CVE-2024-39908

@alyssais alyssais requested review from proteansec and removed request for proteansec September 6, 2024 17:09
@alyssais alyssais added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 6, 2024
@ofborg ofborg bot requested a review from manveru September 6, 2024 18:35
@stahnma stahnma force-pushed the update_ruby_to_335 branch 2 times, most recently from bd2e2a6 to 81e7f97 Compare September 6, 2024 19:32
@fabianhjr fabianhjr marked this pull request as draft September 6, 2024 23:05
@fabianhjr
Copy link
Member

Will switch target branch to staging

@fabianhjr
Copy link
Member

merge base is a bit behind, rebasing.

git merge-base origin/staging origin/master
39ffb3c418ea26f698163e3cd8b4ffb0e4fe705d

@fabianhjr fabianhjr changed the base branch from master to staging September 6, 2024 23:10
@fabianhjr fabianhjr marked this pull request as ready for review September 6, 2024 23:10
@fabianhjr fabianhjr added backport staging-24.05 Backport PR automatically and removed backport release-24.05 Backport PR automatically labels Sep 6, 2024
@alyssais alyssais merged commit a487044 into NixOS:staging Sep 7, 2024
28 of 30 checks passed
@alyssais
Copy link
Member

alyssais commented Sep 7, 2024

Good first PR, thanks!

github-actions bot pushed a commit that referenced this pull request Sep 7, 2024
@stahnma @github-actions
ruby: 3.3.4 -> 3.3.5 (#340137)
838fcef 
Fixes: CVE-2024-43398
Fixes: CVE-2024-41946
Fixes: CVE-2024-41123
Fixes: CVE-2024-39908
(cherry picked from commit a487044)
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Successfully created backport PR for staging-24.05:

@github-actions github-actions bot mentioned this pull request Sep 7, 2024
Merged
1 task
alyssais pushed a commit that referenced this pull request Sep 7, 2024
@stahnma @alyssais
ruby: 3.3.4 -> 3.3.5 (#340137)
cac1d42 
Fixes: CVE-2024-43398
Fixes: CVE-2024-41946
Fixes: CVE-2024-41123
Fixes: CVE-2024-39908
(cherry picked from commit a487044)
@kachick kachick mentioned this pull request Nov 20, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru Awaiting requested review from manveru

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: ruby 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 12. first-time contribution This PR is the author's first one; please be gentle! backport staging-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stahnma @alyssais @fabianhjr @tomberek @NixOSInfra