rathole: 0.5.0 -> 0.5.0-unstable-2024-06-06 #337095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssais
previously requested changes
Aug 24, 2024
ofborg
bot
added
11.by: package-maintainer
xokdvium
force-pushed
the
dev/fix-rathole-rust
branch
2 times, most recently
from
9f3136e to
cdb86bd
Compare
|
@ofborg eval |
xokdvium
force-pushed
the
dev/fix-rathole-rust
branch
from
cdb86bd to
80bd447
Compare
SuperSandro2000
approved these changes
Aug 25, 2024
alyssais
reviewed
Aug 26, 2024
pkgs/by-name/ra/rathole/package.nix
Outdated
| @@ -30,18 +30,20 @@ rustPlatform.buildRustPackage rec { | |||
|
|
|||
| __darwinAllowLocalNetworking = true; | |||
|
|
|||
| doCheck = false; # https://github.com/rapiz1/rathole/issues/222 | |||
| doCheck = true; | |||
- Update to [be14d12](rapiz1/rathole@be14d12), which has Rust 1.80 fixes - Re-enable doCheck - Add myself as maintainer - Sort meta attributes - Remove with lib; usage - Drop changelog for unstable version, since upstream does not track unreleased changes
xokdvium
force-pushed
the
dev/fix-rathole-rust
branch
from
80bd447 to
7fcb06a
Compare
|
Hi, may I know can you all merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes build failure introduced with Rust 1.80. See tracking issue: #332957.
The necessary time crate bump is already in main: rapiz1/rathole#380
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.