Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift: mark as broken on darwin #324593

Merged
merged 1 commit into from
Jul 5, 2024
Merged

swift: mark as broken on darwin #324593

merged 1 commit into from
Jul 5, 2024

Conversation

Guanran928
Copy link
Contributor

@Guanran928 Guanran928 commented Jul 4, 2024

Description of changes

https://hydra.nixos.org/job/nixpkgs/trunk/swiftPackages.swift-unwrapped.x86_64-darwin
https://hydra.nixos.org/job/nixpkgs/trunk/swiftPackages.swift-unwrapped.aarch64-darwin

#320900 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 4, 2024
@Guanran928 Guanran928 requested a review from a team July 4, 2024 17:44
@DontEatOreo
Copy link
Member

Result of nixpkgs-review pr 324593 run on aarch64-darwin 1

@veprbl veprbl merged commit b9d5f7c into NixOS:master Jul 5, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants