-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitlab: 16.10.6 -> 16.11.4 #319486
gitlab: 16.10.6 -> 16.11.4 #319486
Conversation
I'm confused about this test As what I see is failure since the last staging-next (PR #316075), with lots of "Early termination of worker" and the test timing out (locally and on Hydra). This PR doesn't help that issue, according to my testing, but the CI here looked like success :-/ This test failure blocks |
Both *-linux passed the test in ofBorg. So that is weird. |
227d717
to
e34d62d
Compare
Even after rebasing to the latest master commit, the NixOS test is still building fine for me locally. |
It passed for me now. So I'm not sure if I made a mistake when trying this PR atop nixpkgs master? (and it's actually fixing the test) Or is it flaky? |
I think this PR solves the test failure. |
Let's just merge this, it's a security fix and blocks the channel. |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-319486-to-release-23.11 origin/release-23.11
cd .worktree/backport-319486-to-release-23.11
git switch --create backport-319486-to-release-23.11
git cherry-pick -x 7e9c87c67b97efa5c174fde31426a5df2369ab72 e34d62d869c3fbd23ab7440628bfea28b1e176c2 |
Successfully created backport PR for |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.