gawk: move gawkbug to gawkInteractive #314720
Conversation
ofborg
bot
added
10.rebuild-darwin-stdenv
tie
added
the
12.approvals: 1
wegank
removed
the
12.approvals: 1
|
Hm, might as well move gawkbug to |
tie
changed the title
|
The PR originally removed gawkbug altogether, I’ve updated it to keep it only for gawkInteractive. |
wegank
added
the
12.approvals: 2
|
@alyssais, gentle ping, is this good for merge? |
|
@AndersonTorres, gentle ping, is this good for merge? FWIW, this package is part of the stdenv and also doesn't have a maintainer now, #327779 😬 |
|
@philiptaron, added you as a reviewer if you don’t mind looking at this. |
pkgs/tools/text/gawk/default.nix
Outdated
| remove-references-to -t "$NIX_CC" -- "$out"/bin/gawkbug | ||
| patchShebangs --host -- "$out"/bin/gawkbug | ||
| '' else '' | ||
| rm -- "$out"/bin/gawkbug |
There was a problem hiding this comment.
Also FYI: we don't need -- here because $out always starts with a slash.
There was a problem hiding this comment.
Fixed.
Note: I don’t think that’s documented in either Nix or Nixpkgs (i.e. that output paths are guaranteed to be absolute paths)…
This change removes gawkbug program from non-interactive build, similar
to the bash{,Interactive} package.
tie
added
12.approvals: 3+
There was a problem hiding this comment.
Result of nixpkgs-review pr 314720 run on x86_64-linux 1
2 packages built:
- gawkInteractive
- gawkInteractive.info (gawkInteractive.info.info)
|
Thank you!
Oh, I guess I could have rebased to master 😅 Well, the parent PR is targeting staging as well, so might be easier to rebase it though… |
|
No, I just used the |
|
Ah, OK. I generally manually copy-paste |
Description of changes
This change removes gawkbug program from non-interactive build, similar to the bash{,Interactive} package.
Parent PR:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.